[Response Ops][Task Manager] Add new configurable values #190934
Conversation
ymao1
changed the title
| @@ -67,9 +73,17 @@ const requestTimeoutsConfig = schema.object({ | |||
|
|
|||
| export const configSchema = schema.object( | |||
| { | |||
| active_nodes_lookback: schema.number({ | |||
| defaultValue: DEFAULT_ACTIVE_NODES_LOOK_BACK_S, | |||
| min: 10, | |||
There was a problem hiding this comment.
not sure if we should set a max as well?
There was a problem hiding this comment.
Would 5 minutes make sense? If a user sets 5m, it would take 5m for a node that crashed to disappear from the list of active nodes. Perhaps its a sufficient high bound that we'd want to support?
| allow_reading_invalid_state: schema.boolean({ defaultValue: true }), | ||
| /* The number of normal cost tasks that this Kibana instance will run simultaneously */ | ||
| capacity: schema.maybe(schema.number({ min: MIN_CAPACITY, max: MAX_CAPACITY })), | ||
| discovery_interval: schema.number({ | ||
| defaultValue: DEFAULT_DISCOVERY_INTERVAL_MS, | ||
| min: DEFAULT_DISCOVERY_INTERVAL_MS, |
There was a problem hiding this comment.
not sure if we should set a max as well?
There was a problem hiding this comment.
I could see 1 or 5 minutes as the max, we could allow a smaller min, maybe 1s or so?
There was a problem hiding this comment.
Updated in 730d933 to set max of 5 minutes
ymao1
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Would putting these new discovery configs under a name space (like discovery.) be better?
| @@ -32,6 +32,12 @@ export const DEFAULT_WORKER_UTILIZATION_RUNNING_AVERAGE_WINDOW = 5; | |||
| export const CLAIM_STRATEGY_UPDATE_BY_QUERY = 'update_by_query'; | |||
| export const CLAIM_STRATEGY_MGET = 'mget'; | |||
|
|
|||
| export const DEFAULT_DISCOVERY_INTERVAL_MS = 1000 * 10; | |||
|
|
|||
| export const DEFAULT_ACTIVE_NODES_LOOK_BACK_S = 30; | |||
There was a problem hiding this comment.
Maybe duration format like 1s 1h. we already have validateDurationSchema
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @ymao1 |
Resolves #190734
Summary
Making the following configurable: